ttk
ttk copied to clipboard
topology-tool-kit
Compact Triangulation Cache Size Everywhere
Hi all,
I noticed every filter has now a Compact Triangulation Cache Size property. Is this intentional? Especially in the node editor this clutters the view.
this property was introduced in PR #674 and yes, this is intentional. however, I've just realized it was not in advanced visibility mode (which was not intentional).
commit c34e97caf0ea39b4c78e29880ee69d736ba6deac may fix this issue. thanks for letting me know if that works out for you.
I'm not a fan of this. I think this should be a dedicated filter similar to PeriodicGrid.
Debug level and thread numbers are relevant for the majority of filters, but this can not be said about the triangulation cache.
The filter CompactTriangulationPreconditioning will indeed switch on the compact triangulation support (pretty much like the PeriodicGrid filter) and trigger the computation of the compact triangulation.
This is the "off-line" part of the data structure if you will (preconditioning).
However, the CompactTriangulationCacheSize is a parameter which is used at query time, i.e. when used by a filter.
So this can be tuned at a filter level, pretty much like the number of thread or the debug level.
My understanding is that this parameter must be tuned depending on the algorithm under consideration (whether or not it requires significant triangulation preconditioning) for optimal performance.
@guoxiliu could give you more information about that.
did c34e97c (at least partially) solve your issue?
Just as @julien-tierny said, the CompactTriangulationCacheSize is a parameter used at the filter level, and different filters may prefer different cache sizes. But I agree with @JonasLukasczyk, it is kind of annoying to see that in every filter. Ideally, the property should only appear when the compact triangulation is going to be used, i.e., the input dataset has the ttkCompactTriangulationIndex field. I don't know how to make it show the property based on a specific condition. Do you all have any ideas about it?
I will investigate if it is possible to show/hide a paraview property widget based on the existence of a scalar array.