Magisk icon indicating copy to clipboard operation
Magisk copied to clipboard

Magisk reports ambiguous error for invalid module zip

Open mokurin000 opened this issue 1 year ago • 2 comments

Device: POCO F2 Pro Android version: 14 Magisk version name: 070719db Magisk version code: 28001

When try to install a module without META-INF/com/google/android/updater-script (mis-typed as update-script), Magisk just complains '!Unzip error', no useful error hint was given.

mokurin000 avatar Nov 29 '24 08:11 mokurin000

Yeah, I agree that we should print something more useful. Related code:

https://github.com/topjohnwu/Magisk/blob/b32d7bfafd2da3092ecc4720fd9fd1e3c041a808/app/core/src/main/java/com/topjohnwu/magisk/core/tasks/FlashZip.kt#L50-L62

canyie avatar Nov 29 '24 08:11 canyie

https://github.com/topjohnwu/Magisk/pull/8416

aviraxp avatar Nov 29 '24 08:11 aviraxp