Magisk icon indicating copy to clipboard operation
Magisk copied to clipboard

In app Updater, not working, no error message on Samsung Fold 4

Open Conan179 opened this issue 1 year ago โ€ข 25 comments

Hello, I have a problem updating the app, the Canary version, it ran without errors, but the version hasn't changed.

https://github.com/user-attachments/assets/aab1a2ea-56d6-401e-813a-9cad7cbfdeb1

As requested, I switched to Debug and the update works now.

Device: Samsung Fold 4 Android version: 14 Magisk version name: Magisk v28.0 (canary and debug) Magisk version code: 28001

Conan179 avatar Oct 10 '24 17:10 Conan179

Same here on my OnePlus 6 android 11. Debug version did not work for me.

macerg avatar Oct 11 '24 00:10 macerg

install v28.0 apps,then patch boot.img to magisk-28000-xxx.img. last, reflash boot the magisk-28000-xx.img to phone.

kyrenlee avatar Oct 11 '24 00:10 kyrenlee

install v28.0 apps,then patch boot.img to magisk-28000-xxx.img. last, reflash boot the magisk-28000-xx.img to phone.

You may have misunderstood the issue here.

macerg avatar Oct 11 '24 01:10 macerg

duplicated https://github.com/topjohnwu/Magisk/issues/8448

aviraxp avatar Oct 11 '24 01:10 aviraxp

duplicated #8448

I think this is a different issue.

macerg avatar Oct 11 '24 04:10 macerg

@aviraxp No its not a duplicated from 8448. On my screencap, you can see, the download are finish without error. My problem is the install process from the app.

Conan179 avatar Oct 11 '24 09:10 Conan179

I tried myself and it works without issues. Please provide log if the issue is reproducible.

aviraxp avatar Oct 12 '24 16:10 aviraxp

Your issue is duplicated https://github.com/topjohnwu/Magisk/issues/8448

https://github.com/user-attachments/assets/724c4401-fbbf-40b7-a2b9-68f55ed1341c Video showing 'error downloading file''.

aviraxp avatar Oct 13 '24 02:10 aviraxp

No is it NOT. If you look closely at my screen capture above, you can see that the download was SUCCESSFUL and the installation process has started. It even says "Magisk Updated" at the top. Google Protect has even checked the downloaded apk file.

Conan179 avatar Oct 14 '24 09:10 Conan179

No is it NOT. If you look closely at my screen capture above, you can see that the download was SUCCESSFUL and the installation process has started. It even says "Magisk Updated" at the top. Google Protect has even checked the downloaded apk file.

I am repsonding to @macerg 's comment, not yours. Also if you respond thmub up with the comment that ask you to provide logs, i think i have no way but close the issue, as i can never reproduce it.

aviraxp avatar Oct 14 '24 09:10 aviraxp

No is it NOT. If you look closely at my screen capture above, you can see that the download was SUCCESSFUL and the installation process has started. It even says "Magisk Updated" at the top. Google Protect has even checked the downloaded apk file.

I am repsonding to @macerg 's comment, not yours. Also if you respond thmub up with the comment that ask you to provide logs, i think i have no way but close the issue, as i can never reproduce it.

Well , I can reproduce it consistently. Two different scenarios. By trying the update from the magisk manager app, the download fails, as shown in my screen recording, if download from GitHub, download succeeds but install goes ahead but does absolutely nothing. I remain at 27.

macerg avatar Oct 14 '24 10:10 macerg

Same issue as macerg. The in-app updater fails, installing the .apk from Github runs but it remains at version 27.

Xiaomi 14 with PIF, Shamiko and LSPosed (Zygisk).

towe96 avatar Oct 14 '24 18:10 towe96

After installing v28 from GitHub, stable still shows v27 123

njtony11 avatar Oct 15 '24 14:10 njtony11

After installing v28 from GitHub, stable still shows v27 123

Same here

macerg avatar Oct 16 '24 01:10 macerg

After installing v28 from GitHub, stable still shows v27

same here on Xiaomi MI13 Pro with HyperOS 1.0.2 also it does not install from recovery with zip nor by patching and flashing boot.img and init_boot.img from the app and from fastboot the 27000 work well at least with the fastboot mode photo_5807628462842824316_y

stetorIT avatar Oct 18 '24 17:10 stetorIT

Appears to have been fixed. Installed ok now for me. From in app updater. Thanks for fixing, in my case, at least.

macerg avatar Oct 19 '24 12:10 macerg

Appears to have been fixed. Installed ok now for me. From in app updater. Thanks for fixing, in my case, at least.

I'm afraid you just somehow got lucky. Nothing has changed at least on my end. What's more, thefe doesn't even seem to be a new release, so you were installing the same apk which has been failing for us

tajnymag avatar Oct 19 '24 12:10 tajnymag

Appears to have been fixed. Installed ok now for me. From in app updater. Thanks for fixing, in my case, at least.

I'm afraid you just somehow got lucky. Nothing has changed at least on my end. What's more, thefe doesn't even seem to be a new release, so you were installing the same apk which has been failing for us

How peculiar! ๐Ÿคจ

macerg avatar Oct 19 '24 12:10 macerg

Sorry for the non standard approach but I know no other method. Since upgrading to 28.0 (28000) many of my apps {eg, Nationwide) are failing security checks. I need to revert to 27000 urgently because I am dependant on these apps. Can I just install the 27000 app over 28000 and repatch from the 27000 once installed or do I need to reflash from twrp? Please assist, desperate! OnePlus 6 on Android 11. Original install was done via twrp. Thanks ๐Ÿ™ in anticipation.

macerg avatar Oct 20 '24 05:10 macerg

Sorry for the non standard approach but I know no other method. Since upgrading to 28.0 (28000) many of my apps {eg, Nationwide) are failing security checks. I need to revert to 27000 urgently because I am dependant on these apps. Can I just install the 27000 app over 28000 and repatch from the 27000 once installed or do I need to reflash from twrp? Please assist, desperate! OnePlus 6 on Android 11. Original install was done via twrp. Thanks ๐Ÿ™ in anticipation.

That's a different issue

tajnymag avatar Oct 20 '24 06:10 tajnymag

Sorry for the non standard approach but I know no other method. Since upgrading to 28.0 (28000) many of my apps {eg, Nationwide) are failing security checks. I need to revert to 27000 urgently because I am dependant on these apps. Can I just install the 27000 app over 28000 and repatch from the 27000 once installed or do I need to reflash from twrp? Please assist, desperate! OnePlus 6 on Android 11. Original install was done via twrp. Thanks ๐Ÿ™ in anticipation.

That's a different issue I know "it's a different issue" what is the correct method to try and get help please as it's obviously not a 'bug'. Just desperate for a solution.

macerg avatar Oct 20 '24 06:10 macerg

Same issue here, unable to finish magisk installation, thus unable to open the magisk app at all now. device nio running lineageOS 21

Bryantdl7 avatar Oct 22 '24 22:10 Bryantdl7

Now the error also occurs for me with the debug version when I try to update the app from 28001 to 28002, no error message, exactly the same behavior as in my video above.

Conan179 avatar Dec 01 '24 23:12 Conan179

https://www.dropbox.com/scl/fi/9y81lhukhy13pp604bpet/2024-12-04-10.45.23.mp4?rlkey=npr1fy05b4b6wj82dzaam57k4&dl=0

Conan179 avatar Dec 04 '24 09:12 Conan179

Aaaaah I found my mistake, Magisk must NOT be hidden for me, when I restore it, the installation works immediately.

Conan179 avatar Dec 04 '24 09:12 Conan179