Magisk icon indicating copy to clipboard operation
Magisk copied to clipboard

Remove incorrect instruction of resetprop

Open aviraxp opened this issue 9 months ago • 3 comments

This instruction is wrong because the prop doesn't exist when boot is not completed.

aviraxp avatar May 10 '24 07:05 aviraxp

cc @yujincheng08

aviraxp avatar May 10 '24 07:05 aviraxp

I intentionally didnt write it in a while-loop for non-existent props, because not all the people like the sleep 1.

yujincheng08 avatar May 10 '24 08:05 yujincheng08

Why not use this?

while [ "$(getprop sys.boot_completed)" != "1" ]; do
  sleep 1
done

Does resetprop -w have any advantages over it? It is more compatible than resetprop -w

vvb2060 avatar May 10 '24 12:05 vvb2060

This instruction is wrong because the prop doesn't exist when boot is not completed.

dxkf177 avatar May 12 '24 16:05 dxkf177

Was trying to dismiss 🫤

osm0sis avatar May 14 '24 16:05 osm0sis