Magisk icon indicating copy to clipboard operation
Magisk copied to clipboard

Bring biometric back to fix fingerprint auth on some ROMs.

Open Kissycat opened this issue 1 year ago • 6 comments

Not every ROMs support device credential, to support more devices add magisk biometric back please.. Tested. S31201-20065897

Kissycat avatar Dec 01 '23 12:12 Kissycat

We host authentication to systemui, if your device's systemui does not support biometrics, then neither does magisk. Device credential is the basic authentication method and should be supported by all Android devices. If not, you may be using a supervised device, and we don't recommend using magisk in this device.

vvb2060 avatar Dec 01 '23 12:12 vvb2060

In fact, I don't think it's possible to have a device that doesn't support device credential. Can you screen record to show us what is happening on your device?

vvb2060 avatar Dec 01 '23 12:12 vvb2060

https://github.com/topjohnwu/Magisk/assets/20614068/9a2ebec9-1f4f-44fe-b4ab-6283d3f12e41

Can you screen record to show us what is happening on your device?

Sure, here it is, meizu flyme, only support pin with device credential... It happens after I upgrade to v26.4 yesterday.

Kissycat avatar Dec 01 '23 12:12 Kissycat

I understand, your systemui does not allow our authentication requests to use biometrics.

vvb2060 avatar Dec 01 '23 12:12 vvb2060

I understand, your systemui does not allow our authentication requests to use biometrics.

Yes, actually not only your magisk's , I come across same situation with chrome web app, but other app like Play store, 2FAS Auth, ice Box and anything else, my biometric auth works well.

Even with magisk, it works correctly before commit 678c07f.

Kissycat avatar Dec 01 '23 13:12 Kissycat

@vvb2060 Good night, I noticed that the request is still not being processed, is this due to more one switches being too cumbersome? I just made the modification as shown in the picture. S31202-19160561

In this case, can this request be merged?

Kissycat avatar Dec 02 '23 11:12 Kissycat