Magisk icon indicating copy to clipboard operation
Magisk copied to clipboard

Unable to hide magisk manager by renaming package ID!

Open RamuSriram opened this issue 2 years ago • 26 comments

Please help me, unable to rename the package of magisk. After hiding magisk the renamed app gets crashed when tried to open but after uninstalling it, the main magisk app still works. What's the reason behind the crash of renamed package ID app? How can it be fixed now? Attached screenshot of error while opening after renaming. I am using OnePlus 9RT device with Android 13. Build number of my device is MT2111_11_F.13 Also attached the magisk log

Screenshot_2022-12-28-09-08-45-91_b783bf344239542886fee7b48fa4b892

Device: OnePlus 9RT Android version: Android 13 Magisk version name: 831a398b (25206) (D) Magisk version code: 831a398b (25206) (D) magisk_log_2022-12-28T12.35.13.log

RamuSriram avatar Dec 28 '22 07:12 RamuSriram

upload crash log

vvb2060 avatar Dec 28 '22 09:12 vvb2060

I don't see any relative content from your log and I suspect if you are really using the debug version. Please reproduce the problem and provide full adb logcat. Otherwise, this issue will be closed again.

yujincheng08 avatar Dec 28 '22 09:12 yujincheng08

Ok, wait. I will send ADB logcat in a while. Meanwhile, watch the attached video where I'm reproducing the problem.

https://anonfiles.com/a9r5T8Odya/Record_2022-12-28-16-01-51_mp4

RamuSriram avatar Dec 28 '22 10:12 RamuSriram

your magisk app is debug version but the installed magisk is not

yujincheng08 avatar Dec 28 '22 11:12 yujincheng08

Okay, I have installed magisk debug now, still facing the same issue. Attaching new log. magisk_log_2022-12-28T16.56.53.log Screenshot_2022-12-28-16-57-24-20_785cfb1f0fb0c9a2030c9b38a1c3479a

RamuSriram avatar Dec 28 '22 11:12 RamuSriram

I think I said we need full adb logcat.

yujincheng08 avatar Dec 28 '22 11:12 yujincheng08

I think I said we need full adb logcat.

Yes, please wait. I will send it after few hours. I am currently away from my PC.

RamuSriram avatar Dec 28 '22 11:12 RamuSriram

you can use logcat reader or so to get one.

yujincheng08 avatar Dec 28 '22 11:12 yujincheng08

you can use logcat reader or so to get one.

Okay, trying.

RamuSriram avatar Dec 28 '22 11:12 RamuSriram

you can use logcat reader or so to get one.

Here is the log from Logcat Reader logcat_12-28-2022_17-08-01.txt

RamuSriram avatar Dec 28 '22 11:12 RamuSriram

Unable to instantiate appComponentFactory
java.lang.ClassNotFoundException: Didn't find class "y.B" on path: DexPathList[[zip file "/data/app/~~CCXhtw6Pdcg2iY2I8Xki7A==/lk.ke-cZTuuq0nfFyzrnfrrAgXhw==/base.apk"],nativeLibraryDirectories=[/data/app/~~CCXhtw6Pdcg2iY2I8Xki7A==/lk.ke-cZTuuq0nfFyzrnfrrAgXhw==/lib/arm64, /system/lib64, /system_ext/lib64]]
	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
	at android.app.LoadedApk.createAppFactory(LoadedApk.java:283)
	at android.app.LoadedApk.createOrUpdateClassLoaderLocked(LoadedApk.java:1059)
	at android.app.LoadedApk.getClassLoader(LoadedApk.java:1149)
	at android.app.LoadedApk.getResources(LoadedApk.java:1404)
	at android.app.ContextImpl.createAppContext(ContextImpl.java:3128)
	at android.app.ContextImpl.createAppContext(ContextImpl.java:3120)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7049)
	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2288)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:240)
	at android.os.Looper.loop(Looper.java:351)
	at android.app.ActivityThread.main(ActivityThread.java:8321)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1012)

vvb2060 avatar Dec 28 '22 16:12 vvb2060

upload repacked apk (/data/app/~~CCXhtw6Pdcg2iY2I8Xki7A==/lk.ke-cZTuuq0nfFyzrnfrrAgXhw==/base.apk)

vvb2060 avatar Dec 28 '22 16:12 vvb2060

upload repacked apk (/data/app/~~CCXhtw6Pdcg2iY2I8Xki7A==/lk.ke-cZTuuq0nfFyzrnfrrAgXhw==/base.apk)

Okay, Please wait.

RamuSriram avatar Dec 28 '22 16:12 RamuSriram

upload repacked apk (/data/app/~~CCXhtw6Pdcg2iY2I8Xki7A==/lk.ke-cZTuuq0nfFyzrnfrrAgXhw==/base.apk)

This. https://anonfiles.com/u7M6V7O6y8/base_apk

It is from different path (different package name) though as I have recreated.

The new path of the repacked apk is /data/app/~~Ot-FYWYKNcL5PgNsACCgKQ==/khcx.hidaqt--dsDbkCJ3cwgzh3EkgVyNg==/base.apk

RamuSriram avatar Dec 28 '22 16:12 RamuSriram

#6475 fixed

wait next canary release

vvb2060 avatar Dec 28 '22 17:12 vvb2060

#6475 fixed

wait next canary release

Okay. Waiting. Thanks :)

RamuSriram avatar Dec 28 '22 17:12 RamuSriram

if you can't wait, you can use ci build https://github.com/topjohnwu/Magisk/actions/runs/3784407872

vvb2060 avatar Dec 28 '22 17:12 vvb2060

if you can't wait, you can use ci build https://github.com/topjohnwu/Magisk/actions/runs/3784407872

Pro brother, It Worked 😳 Thanks a lot for the quick response & solution :)

RamuSriram avatar Dec 28 '22 17:12 RamuSriram

if you can't wait, you can use ci build https://github.com/topjohnwu/Magisk/actions/runs/3784407872

Btw can I know was it because of main app downloading issue through Stub APK? Server side issue? Or app bug?

RamuSriram avatar Dec 28 '22 17:12 RamuSriram

I think topjohnwu may have a little problem when compiling, the compiled apk is broken.

vvb2060 avatar Dec 28 '22 17:12 vvb2060

I think topjohnwu may have a little problem when compiling, the compiled apk is broken.

Okay 👍

RamuSriram avatar Dec 28 '22 17:12 RamuSriram

https://github.com/topjohnwu/Magisk/actions/runs/3780156739

Because this ci build is fine. anyway, #6475 can prevent this from happening again in the future.

vvb2060 avatar Dec 28 '22 17:12 vvb2060

https://github.com/topjohnwu/Magisk/actions/runs/3780156739

Because this ci build is fine. anyway, #6475 can prevent this from happening again in the future.

Yeah, it's working fine too 👍

RamuSriram avatar Dec 28 '22 18:12 RamuSriram

Not fixed in the future updates yet. Only in the 78f1b499 (25206) actually have the fix - for the new canary/debug build version it needs to be fixed manually.

https://github.com/topjohnwu/Magisk/actions/runs/3780156739 Because this ci build is fine. anyway, #6475 can prevent this from happening again in the future.

Yeah, it's working fine too 👍

TaurineRepo avatar Jan 03 '23 20:01 TaurineRepo

Unhide "off-topic" comment to get ability to see the comment that is not off-topic but I think that dev thinks that it's off-topic.

TaurineRepo avatar Jan 04 '23 00:01 TaurineRepo

https://github.com/topjohnwu/Magisk/actions/runs/3780156739

Because this ci build is fine. anyway, #6475 can prevent this from happening again in the future.

~Hello, how to make it work in WorkSpace profile? Same magisk package name can't be present in both main & work profiles?~

Update : Working fine in new CI Builds 👍

RamuSriram avatar Jan 14 '23 07:01 RamuSriram