topjohnwu
Magisk Manager: modules list module block focusable but not highlighed on select on Android TV 7 and Fire OS 6
In Manager, when controlled with remote, there is focus but no highlight on module block and user need to navigate Up/Down twice on each module (opposite behavior for example on DenyList). And there is still NextFocusRight to On/Off switch on that block - https://github.com/topjohnwu/Magisk/blob/a3381da7ed845a718c2e25955774b3f83063cd83/app/src/main/res/layout/item_module_md2.xml#L31
Device: Fire TV 4K Android version: Fire OS 6 / Android 7 Magisk version name: 24315 Magisk version code: 24315
If you want to leave current behavior when only switches and buttons can be clickable, CardView must be set as focusable="false" (as was done before for include_home_m* Manager XML layouts on Home) and nextFocusRight="@id/module_indicator" must be removed. Other way to make card clickable as in #5923 and focused depending of module state - in that case module card can be focused and highlighted when selected and it will be not focused and there will be only switch and buttons navigation on it when module not enabled.
Environment
Device: oppo reno6 5g Android version:12 Magisk version name:app-debug.apk Magisk version code:25001
inaccessible or not found
OP4ED5:/ $ echo $PATH /product/bin:/apex/com.android.runtime/bin:/apex/com.android.art/bin:/system_ext/bin:/system/bin:/system/xbin:/odm/bin:/vendor/bin:/vendor/xbin OP4ED5:/ $ ls acct cache data_mirror init metadata my_company my_preload my_version postinstall second_stage_resources system apex config debug_ramdisk init.environ.rc mnt my_engineering my_product odm proc special_preload system_ext bin d dev init.environ.rc.patch my_bigball my_heytap my_region odm_dlkm product storage vendor bugreports data etc linkerconfig my_carrier my_manifest my_stock oem sdcard sys vendor_dlkm OP4ED5:/ $ su OP4ED5:/ # ls /system/bin/sh: ls: inaccessible or not found 127|OP4ED5:/ # export PATH="/product/bin:/apex/com.android.runtime/bin:/apex/com.android.art/bin:/system_ext/bin:/system/bin:/system/xbin:/odm/bin:/vendor/bin:/vendor/xbin" OP4ED5:/ # ls acct cache data_mirror init metadata my_company my_preload my_version postinstall second_stage_resources system apex config debug_ramdisk init.environ.rc mnt my_engineering my_product odm proc special_preload system_ext bin d dev init.environ.rc.patch my_bigball my_heytap my_region odm_dlkm product storage vendor bugreports data etc linkerconfig my_carrier my_manifest my_stock oem sdcard sys vendor_dlkm OP4ED5:/ #
The problem is that basic commands like ls logcat are available when I am not su, and once I am SU, all basic commands are prompted /system/bin/sh: ls: Inaccessible or not found . When I reworked export PATH, all the basic commands worked
