Magisk icon indicating copy to clipboard operation
Magisk copied to clipboard

Suggestion: show a confirmation dialog before installing a module from filesystem

Open Fs00 opened this issue 3 years ago • 4 comments

Hello everyone, I'd like to propose a small QoL change to the Magisk app. Currently, when you install a module from the filesystem, the installation starts as soon as the ZIP gets selected from the file picker. This is far from ideal since, if you select the wrong ZIP by mistake (e.g. when you have multiple modules in the same folder), there is no way to go back before the installation starts. Therefore I propose to add a confirmation dialog that should appear after the user selects the ZIP, which also displays basic information on the module that is about to be installed (author, name, version). This last addition would be very helpful to make sure that the right file has been selected. Thanks!

-- Device: not relevant Android version: any Magisk version name: 23.0 Magisk version code: 23001

Fs00 avatar Aug 14 '21 12:08 Fs00

Yes this is important. But my question is what happens to magisk without the creator 😶

techIndia-hacker avatar Aug 25 '21 12:08 techIndia-hacker

Can magisk flashing from file not working be caused by not allowing riru to update; past point of edcxposed no more working

spoxed avatar Oct 03 '21 19:10 spoxed

No.

techIndia-hacker avatar Oct 04 '21 02:10 techIndia-hacker

Even support this request

elschman avatar Feb 22 '22 10:02 elschman

This needs a new bump

stylemessiah avatar Jan 18 '23 00:01 stylemessiah