ormar-postgres-extensions icon indicating copy to clipboard operation
ormar-postgres-extensions copied to clipboard

Published 20 hours ago • verified publisher icon tophat

[fix] codecov 2.1.12 was removed from pypi and later reinstated as 2.1.13

Open estarfoo opened this issue 10 months ago • 2 comments

Cf. https://about.codecov.io/blog/message-regarding-the-pypi-package/

Description

Bump dev dependency codecov version from 2.1.12 to 2.1.13. Apparently the package was deprecated by its owner and removed entirely from pypi, then readded as a final, unmaintained 2.1.13 version. The hard dependency on 2.1.12 fails in the pipeline, and I hope that 2.1.13 would do the trick as drop-in replacement and help evaluate other PRs (which fail due to this issue).

Checklist

  • [x] This PR has sufficient documentation.
  • [x] This PR has sufficient test coverage.
  • [x] This PR title satisfies semantic convention. // (No release required just for this.)

Additional Comments

No additional comments.

estarfoo avatar Apr 10 '24 14:04 estarfoo

@etimberg, would you prefer the pipeline issues to be addressed in this PR, or separately?

  • https://github.com/tophat/ormar-postgres-extensions/actions/runs/8633161247/job/23776388434?pr=33: the import is unused (the code which was using it is commented out). Remove?
  • https://github.com/tophat/ormar-postgres-extensions/actions/runs/8633161247/job/23776387921?pr=33: I have no idea where and how TWINE_USERNAME and TWINE_PASSWORD are being set in the workflow file, so I can't really debug that part, sorry.

estarfoo avatar May 01 '24 14:05 estarfoo

The import can be removed. Not sure about the TWINE stuff; I'm not at Top Hat anymore so it might be something that someone internally will need to fix

etimberg avatar May 01 '24 15:05 etimberg