topgrade icon indicating copy to clipboard operation
topgrade copied to clipboard

feat: support Poetry

Open SteveLauC opened this issue 9 months ago • 2 comments

Standards checklist:

  • [x] The PR title is descriptive.
  • [x] I have read CONTRIBUTING.md
  • [x] The code compiles (cargo build)
  • [x] The code passes rustfmt (cargo fmt)
  • [x] The code passes clippy (cargo clippy)
  • [x] The code passes tests (cargo test)
  • [ ] Optional: I have tested the code myself

For new steps

  • [x] Optional: Topgrade skips this step where needed

  • [x] Optional: The --dry-run option works with this step

  • [ ] Optional: The --yes option works with this step if it is supported by the underlying command

    cc @MisileLab, does this tool have something like $ poetry self update --yes?

If you developed a feature or a bug fix for someone else and you do not have the means to test it, please tag this person here.

SteveLauC avatar May 06 '24 13:05 SteveLauC

Do you want a binary to test, I can give you a binary of the following platforms:

  • Linux amd64 musl
  • macOS aarch

SteveLauC avatar May 06 '24 13:05 SteveLauC

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 4.26%. Comparing base (767f0d9) to head (169668f).

Files Patch % Lines
src/steps/generic.rs 0.00% 5 Missing :warning:
src/main.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #790      +/-   ##
========================================
- Coverage   6.91%   4.26%   -2.65%     
========================================
  Files         37      33       -4     
  Lines      11645    5935    -5710     
========================================
- Hits         805     253     -552     
+ Misses     10840    5682    -5158     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 13:05 codecov[bot]

Standards checklist:

* [x]  The PR title is descriptive.

* [x]  I have read `CONTRIBUTING.md`

* [x]  The code compiles (`cargo build`)

* [x]  The code passes rustfmt (`cargo fmt`)

* [x]  The code passes clippy (`cargo clippy`)

* [x]  The code passes tests (`cargo test`)

* [ ]  _Optional:_ I have tested the code myself

For new steps

* [x]  _Optional:_ Topgrade skips this step where needed

* [x]  _Optional:_ The `--dry-run` option works with this step

* [ ]  _Optional:_ The `--yes` option works with this step if it is supported by
  the underlying command
  cc @MisileLab, does this tool have something like `$ poetry self update --yes`?

If you developed a feature or a bug fix for someone else and you do not have the means to test it, please tag this person here.

I just see that checklist now, but I think poetry's update is non-interact, so it doesn't need yes option.

MisileLab avatar Jul 03 '24 09:07 MisileLab

Would you like to give this PR a test?

SteveLauC avatar Jul 03 '24 23:07 SteveLauC