apm icon indicating copy to clipboard operation
apm copied to clipboard

Some issues: keep-alive, silence when the application fails to start, no specification of the TOML file and what it does, and not clear how to use environment variables

Open JJ opened this issue 8 years ago • 2 comments

Well, that's pretty much it. Maybe a bit of more explanation:

  • This error when running

    apm: error: required flag --keep-alive not provided, try --help

  • Specify in documentation what, if anything, is needed to include in the config.toml file

  • Do you always have to start the server?

  • How can I add environment variables? Are they sent through to the running process?

  • Not clear if the program has failed to start. I have to use apm status to find out something.

JJ avatar Oct 22 '16 18:10 JJ

  • I didn't quite understand the first issue, are you saying that APM is requiring you to set --keep-alive flag?
  • I'm in the process of improving the documentation as we speak. Thanks for the feedback.
  • Yes, you always have to start the server. I will also add it to the documentation.
  • Environment variables are supposed to be sent through the running process. So you can pass new environment variables ENV_1=xxx ENV_2=yyy apm bin ....
  • You are right, I will make it more verbose when trying to run new processes.

Thank you for your feedback. Based on it, I have a couple of suggestions:

  • Let APM start processes through a JSON file. This JSON file will contain a list of processes, with some info, such as environment variables, flags, keep-alive and other data necessary to run it.
  • Make APM more verbose by adding more information when trying to start, stop, restart new processes.

I'm already working on improving the documentation, I will send a PR really soon.

If you have any more suggestions, please let me know.

MateusDantas avatar Oct 22 '16 19:10 MateusDantas

  • [ ] Investigate possible error with keep-alive flag
  • [ ] Improve documentation to cover more scenarios PR #11
  • [ ] Make APM more verbose to the user
  • [ ] Add a way to explicitly set environment variables when starting processes
  • [ ] Let APM start processes from a structured json file

Maybe the last two tasks can be merged into one, but I will keep them in the meantime so I can have a more clear view of what needs to be done.

MateusDantas avatar Oct 26 '16 10:10 MateusDantas