topaz icon indicating copy to clipboard operation
topaz copied to clipboard

[canary] crashes when i goto towards a character who is in the mog house

Open Chronos77 opened this issue 4 years ago • 4 comments

  • [x] I have searched existing issues (https://github.com/topaz-next/topaz/issues) to see if the issue has already been opened
  • [x] I have checked the commit log to see if the issue has been resolved since my server was last updated
  • [x] This issue occurs on canary branch (if other branch, please specify)

Additional Information (Steps to reproduce/Expected behavior) : Have 2 characters : One on the mog house and one have access to goto commands (GM)

Make command !goto NameOfTheCharacterInTheMog with GM

Server process was kill

Nothing in the log just kill process: last lines:

[07/Feb] [18:03:37] [Action Info]  CLIENT Zant PERFORMING ACTION 07
[07/Feb] [18:03:37] [Info]  parse: 0B5 | 00D2 00D1 0C from user: Fleme
[07/Feb] [18:03:38] [Debug]  Message: Received message 13 from message server
[07/Feb] [18:03:38] [Debug]  Message: Received message 13 from message server

Chronos77 avatar Feb 07 '21 18:02 Chronos77

@claywar Character (noGM) Hume (F) Nation: Bastok Places during the events: Mog House (Bastok mines)

Character (GM) Mithra Nation: Windurst Places during the events: Bastok mines (out of the mog)

Chronos77 avatar Feb 12 '21 12:02 Chronos77

I wonder if its the out of nation vs in nation part causing issues. Was unable to reproduce this morning with two characters both from San d'Oria. Will check this out later today.

ghost avatar Feb 12 '21 14:02 ghost

Another precision for this bug, i think it's "gotoPlayer(target)" function if i comment this it's ok.

I don't know if this line is still useful

if targ and not targ:isInMogHouse() then
     player:setPos(targ:getXPos(), targ:getYPos(), targ:getZPos(), targ:getRotPos(), forceZone == 1 and targ:getZoneID() or nil)
 elseif not player:gotoPlayer(target) then
      error(player, string.format("Player named: %s not found!", target))
 end

Chronos77 avatar Feb 23 '21 00:02 Chronos77

sending forceZone == 1 and targ:getZoneID() or nil where the zoneid arg is for setPos() doesn't look sane to me.

TeoTwawki avatar Mar 01 '21 15:03 TeoTwawki