topaz
topaz copied to clipboard
The position of the boat (manaclipper) is not good
I have:
- [x] searched existing issues (https://github.com/topaz-next/topaz/issues) to see if the issue has already been opened
- [x] checked the commit log to see if the issue has been resolved since my server was last updated
Additional Information (Steps to reproduce/Expected behavior) :
- Go to bibiki bay H-7
- Wait the boat
- When the boat is here, get on the boat
From recent testing on Canaria, this issue also impacts both Mhaura ferries.
There are a few other github issues that mention this, but this is the first with a screenshot so it can stay 👍
I think this is a fairly old bug and is common across lots of pservers. Probably an interesting place to dig in and compare to retail caps
@Chronos77 Do you happen to know which route this issue occurs on? I tried to reproduce yesterday for a bit with no luck, but didn't hit all of the various routes (if that matters). I also got about an hour's worth of captures for this transport point on retail in case we need it.
@claywar, The problem appears on any route from bibiki bay but here is a video to Dhamel rock if it can help
https://user-images.githubusercontent.com/1618002/102691362-39b2ec00-420c-11eb-924e-cdcf58e7ec9e.mp4
Hmm, I'll check that, but it will take some time as I still need to digest the new code, and I don't have looking into FFXI code since long time now.
Question. After depart (CS and all), is back to normal ?
I'm looking at this now.
However, there are a lot comments in russian only. I had to translate those as I don't speak that language.
"Question. After depart (CS and all), is back to normal ?" We have the gap everywhere, even on the island
I didn't checked the airship yet, just the ferries.
This happens because on last FFXI client the pos changed (or stack pointers).
I'm still checking as we lack a command to speed up the time, or setup a specific time for airship, but I will edit all that just for testing.
There is one so far is correct, Mhaura -> Whitegate Boat, but when departs from Mhaura it becomes wrong, arrival is correct.
Whitegate Boat -> Mhaura, depart is correct, except on arrival.
Well, the bug start from !pos command.
The 'y' and 'z' are inverted.
You can figure that by using !pos command.
For Selbina I need to use: !pos 19.2 -1.39 -59 248
And for Mhaura: !pos 9 -1.39 2 249
There are some light bugs in transport.cpp, I fixed those, but the ferry still ain't alright.
The issue starts way back from pos.
Here's the file I changed: https://filebin.net/6xjm47p2cs2wmogq/transport.cpp
Couple light fixes on SQL routine, other simple fixes 'here and there' (you need to compare them if you want to see).
Edited both fmtQuery to make it more "dev friendly".
Added some comments to make it easier to see too.
If I put the boat on right level, this happens (lol):