Synthesis does not fail when players are hit during combat

[topaz-next-bot]

Issue by Era-Lusiphur Thursday Oct 29, 2020 at 12:02:49 Originally opened as: project-topaz/topaz - Issue 1452

---

I have:

• [x] searched existing issues (http://project-topaz.com/issues/) to see if the issue has already been opened
• [x] checked the commit log to see if the issue has been resolved since my server was last updated

Additional Information (Steps to reproduce/Expected behavior) : Synthesis should fail when players receive damage during combat. Currently it does not affect the outcome of the synth. Evaded attacks should not have an effect on synthesis outcome.

Opened issue per Zach.

[topaz-next-bot]

Comment by zach2good Thursday Oct 29, 2020 at 12:06:18

---

I've done about 90s of research, I don't think we have a mechanism for marking items as "un-losable" in a failed synth. If we call doSynthFail (like we do when we're detecting abuse) things like Lu Shangs Rod can be lost - which is not correct in this case.

[topaz-next-bot]

Comment by zach2good Saturday Oct 31, 2020 at 14:36:46

---

I don't remember who said it, but we had a vague confirmation that you lose all items if you're hit (just like if you force a zone during synth).

I'm happy to shift the "responsibility" of this onto server operators. If a player loses their expensive mats or their "unlosable" items in a synth they were attempting in the middle of a fight: they can explain to their local GM why they deserve their items back 🤡