ember-service-worker-update-notify icon indicating copy to clipboard operation
ember-service-worker-update-notify copied to clipboard

Support for Ember 4.x

Open olenderhub opened this issue 2 years ago • 3 comments

Issue: Uncaught (in promise) ReferenceError: Ember is not defined

olenderhub avatar Aug 10 '22 10:08 olenderhub

I created PR for this https://github.com/topaxi/ember-service-worker-update-notify/pull/58

I think it should be enough. Can you check it please?

EDIT: I removed this branch and created new with some changes below

olenderhub avatar Aug 10 '22 15:08 olenderhub

Unfortunately in my PR something still is missing. I tried to use this branch locally and still had this issue.

olenderhub avatar Aug 10 '22 17:08 olenderhub

Probably it was related to ember-cli-htmlbars version. Now I don't see issues locally.

https://github.com/topaxi/ember-service-worker-update-notify/pull/59

Please check it

olenderhub avatar Aug 10 '22 18:08 olenderhub