next-use-contextual-routing icon indicating copy to clipboard operation
next-use-contextual-routing copied to clipboard

Published 20 hours ago • verified publisher icon toomuchdesign

refactor: remove qs-stringify dependency

Open toomuchdesign opened this issue 2 years ago • 1 comments

What kind of change does this PR introduce?

Refactor

What is the new behaviour?

Generate with native URLSearchParams instead of qs-stringify.

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • [X] Tests for the changes have been added
  • [ ] Docs have been added / updated

toomuchdesign avatar Dec 01 '22 14:12 toomuchdesign

Considered creating query strings with URLSearchParams, but learned that browser implementations do more than specs which don't support array of strings.

Therefore leaving this aside for a while since URLSearchParams should work but specs don't say so.

toomuchdesign avatar Dec 05 '22 10:12 toomuchdesign

🦋 Changeset detected

Latest commit: 76752f2615ca4817e0c4f8acd0e71db93e129a52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
next-use-contextual-routing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 08 '24 12:10 changeset-bot[bot]