tap-release icon indicating copy to clipboard operation
tap-release copied to clipboard

STABLE_ASSET_URL and STABLE_ASSET_SHA256 not working

Open shreddedbacon opened this issue 6 years ago • 5 comments

I'm trying to configure tap-release and when I publish a release, tap-release updates the file successfully but it doesn't replace the STABLE_ASSET_URL or STABLE_ASSET_SHA256.

url: "https://github.com/amazeeio/lagoon-cli/releases/download/$STABLE_VERSION/lagoon-cli-${STABLE_VERSION}-darwin-amd64.tar.gz"
tap: amazeeio/homebrew-lagoon-cli/lagoon.rb
template: >
  class Lagoon < Formula
    desc     "Command line tool for interacting with a Lagoon API"
    homepage "https://github.com/amazeeio/lagoon-cli"
    version  "$STABLE_VERSION"
    url      "$STABLE_ASSET_URL"
    sha256   "$STABLE_ASSET_SHA256"

    bottle :unneeded

    def install
      bin.install "lagoon"
    end
  end

It manages to update the STABLE_VERSION fine once it makes its way in fine but the others do not.

class Lagoon < Formula
  desc     "Command line tool for interacting with a Lagoon API"
  homepage "https://github.com/amazeeio/lagoon-cli"
  version  "0.5.2"
  url      "$STABLE_ASSET_URL"
  sha256   "$STABLE_ASSET_SHA256"

  bottle :unneeded

  def install
    bin.install "lagoon"
  end
end

Any ideas?

shreddedbacon avatar Dec 03 '19 05:12 shreddedbacon

After reading the build kite tap-release https://github.com/buildkite/cli/blob/master/.github/tap-release.yml and seeing the tap https://github.com/buildkite/homebrew-cli/blob/master/bk.rb

It seems that STABLE_ASSET_URL and STABLE_ASSET_SHA256 aren't actually supported, and the readme is out of date?

shreddedbacon avatar Dec 05 '19 03:12 shreddedbacon

I've managed to get this working after using the buildkite files as examples.

shreddedbacon avatar Dec 05 '19 03:12 shreddedbacon

I've managed to get this working after using the buildkite files as examples.

@shreddedbacon can you give more info on this? Were you able to use those 2 variables to release a tap of your own?

rogerluan avatar Feb 25 '21 13:02 rogerluan

I've managed to get this working after using the buildkite files as examples.

@shreddedbacon can you give more info on this? Were you able to use those 2 variables to release a tap of your own?

@rogerluan sorry. What were using for tap-releases have been broken for some time now and I haven't had time to look in to why they are broken. This is what our tap-release.yml file looked like though before it was broken. Hope it helps.

asset: "tool-$VERSION_NUMBER-darwin-amd64.tar.gz"
tap: "shreddedbacon/homebrew-tool/tool.rb"
template: >
  class Lagoon < Formula
    desc     "Generic Tool"
    homepage "https://github.com/shreddedbacon/tool"
    version  "$STABLE_VERSION"
    url      "$STABLE_URL"
    sha256   "$STABLE_SHA256"
    bottle :unneeded
    def install
      bin.install "tool"
    end
  end

shreddedbacon avatar Feb 26 '21 05:02 shreddedbacon

All good, thanks for sharing @shreddedbacon ! 💪

rogerluan avatar Feb 26 '21 05:02 rogerluan