t3 icon indicating copy to clipboard operation
t3 copied to clipboard

Shaking off operators breaks connection if Operator has more than one output

Open pixtur opened this issue 2 years ago • 2 comments

Describe the bug A clear and concise description of what the bug is.

Please complete the following information):

  • OS:
  • Version:
  • Graphics card and resolution

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

pixtur avatar Dec 11 '22 20:12 pixtur

Now I understand why shaking was enabled only for nodes without multi-input and output 😺 There are some challenges due to multi-input index order of removing / order of adding the new connections, undo / redo, multiple nodes selected on shaking...

I sent a pull request to show progress and see if I am in the right direction, but don't pull yet. There are still some bugs since there are multiple cases to cover.

The issues are related to the indexes of the multi-input connections, not only regarding shaking but in other parts of the code as well. I can try to look further into the structure and logic of multi-input to find a more robust solution.

sosias avatar Dec 15 '22 01:12 sosias

Ah yes... Multiinput indices are very complex. To be honest, most of that implementation has been done by @drcynic so I'm not really familiar with the details. But I will have a look at your PR.

pixtur avatar Dec 16 '22 20:12 pixtur