reddit-moderator-toolbox icon indicating copy to clipboard operation
reddit-moderator-toolbox copied to clipboard

Make more manifest adjustments in rollup per browser.

Open creesch opened this issue 3 years ago • 1 comments

As the title says. The properties added don't break toolbox like "incognito": "split" does for firefox. But, they do cause error warnings which also isn't ideal so it is better to remove them for the browsers that throw errors.

creesch avatar Aug 30 '22 03:08 creesch

Needs some more testing apparantly... When trying this in firefox it seems toolbox gets stuck somewhere. The only log entry is one for tbstorage

image

I am not sure why as the manifest isn't all that different, it is just one property being different. Of course, firefox being firefox we are likely missing a bunch of errors in the console output.

creesch avatar Aug 30 '22 04:08 creesch

Failure to load in Firefox is due to an error thrown when version_name is missing from the manifest. We load the version name directly from the manifest to avoid duplicating it in multiple places, so if it's not causing breaking errors to leave in the unrecognized key, we should probably just keep that as-is.

image

eritbh avatar Sep 07 '22 20:09 eritbh

Right, I totally forgot about that...

creesch avatar Sep 07 '22 20:09 creesch