reddit-moderator-toolbox icon indicating copy to clipboard operation
reddit-moderator-toolbox copied to clipboard

Published 20 hours ago • verified publisher icon toolbox-team

Modbutton errors not shown to user

Open eritbh opened this issue 5 years ago • 3 comments

When an action is attempted via the mod button and Reddit returns one or more errors in response, we currently just tell the user "This failed, do you want to retry?" even if the errors can't possibly be fixed by retry (e.g. user is a mod, message too long). We should come up with a UI for presenting the errors to the user directly (they're returned with nice strings that can be displayed!) and letting them fix the issue.

This is gonna be a bit weird with the current multi-sub nature of the modbutton window, but we should be able to figure something out.

eritbh avatar Oct 02 '20 06:10 eritbh

Hasn't this been addressed (partially) by #383 ?

creesch avatar Oct 11 '20 19:10 creesch

Hasn't this been addressed (partially) by #383 ?

Not really. #383 added client-side length checks before sending a request, but when requests fail for other reasons, we're still just displaying a generic message and ignoring the error info Reddit sends.

eritbh avatar Oct 11 '20 20:10 eritbh

Gotcha, I should have checked the code for that one first. I just assumed it went of API errors.

creesch avatar Oct 12 '20 10:10 creesch