reddit-moderator-toolbox icon indicating copy to clipboard operation
reddit-moderator-toolbox copied to clipboard

Research if it is feasible to show ban history somewhere for users based on modmail ban message search.

Open creesch opened this issue 5 years ago • 5 comments

I saw that someone made a dedicated extension to display this on all users. I can't however remember where exactly I saw it and it has the potential to be done wrong using up the api ratelimit.

So I am thinking about using modmail search with a query like this:

/api/mod/conversations/search?q=subject%3A"banned from participating in r%2Ftoolbox" participant%3Acreesch

And then possibly show it in the historybutton or modbutton and modmail sidebar. I think that doing it like that will limit the API calls to a reasonable amount.

We could then show something like:

Banned permanently: 2x Banned temporarily: 1x Last ban date: 2019-09-09

Or something along those lines.

~~We could even expand it to include muting.~~ seems like that is now build in with the new mute additions reddit made.

creesch avatar Aug 08 '20 14:08 creesch

@Geo1088 @SpyTec can I get your thoughts on the following?

I was deliberating on adding it to the modbutton (ban history tab or something like that) but I figured that it might make sense to also include it in the historybutton overview. Should we only do that when historybutton is called from a mod subreddit and only show bans for that subreddit, or should we always include it and show bans for all subreddits?

I am inclined to just show all bans but as reddits policy sort of encourages to only judge people based on actions in the sub itself I am not entirely sure.

For historybutton I had something in mind like this

Subreddit Perm Temp Last
/r/sub1 0 2 2017-02-19
/r/sub2 0 1 2019-09-09
/r/sub3 1 0 2020-07-29

On a more practical note, I'll probably end up making a tbAPI function getModmailBanHistory that takes a username and an optional subreddit value (probably also a check if the subreddit is enrolled in new modmail). That way we can show the same data in multiple places. I don't think we really need any caching here as the only place where I think we will show it automatically will be modmail itself and I don't foresee ratelimit issues there.

creesch avatar Aug 10 '20 07:08 creesch

I'd probably throw it in history button only. Mod button is mostly about performing actions, not just getting data, at least in my eyes. I don't have a strong preference for all bans or just bans for the current sub, though it would probably be more consistent if we went for the latter since that's how usernotes are displayed already.

eritbh avatar Aug 10 '20 16:08 eritbh

I'd probably throw it in history button only. Mod button is mostly about performing actions, not just getting data,

Makes sense, my reasoning for it possibly going there is because it is mod actions related and mod button already shows ban data. But as you said it is mostly about performing those actions.

though it would probably be more consistent if we went for the latter since that's how usernotes are displayed already.

Well yeah, but historybutton itself shows data for all subreddits so I was more or less thinking about making it consistent there.

creesch avatar Aug 10 '20 17:08 creesch

but historybutton itself shows data for all subreddits so I was more or less thinking about making it consistent there.

Hadn't thought about that. I like that plan.

eritbh avatar Aug 12 '20 03:08 eritbh