option to ignore self.subreddit posts for domain % highlighting

[naxian]

I love the new yellow/red highlighting for the user domain submission history. It would be handy though if we could have the option to not highlight self.subreddit domains.

Thanks!

[agentlame]

I doubt we will make it optional. But if I can do it in a simple way I will just disable it for self.posts. But my question is do we also ignore reddit.com as a domain? IE: meta and spam link submissions.

[creesch]

My vote is for optional, it still is handy to see what percentage of someones posts are self posts.

If someone makes a 100 perfectly fine selfposts and only two link submissions that happen to be to the same domain the percentage will be off when not including self posts.

[agentlame]

If someone makes a 100 perfectly fine selfposts and only two link submissions that happen to be to the same domain the percentage will be off when not including self posts.

But that would affect highlighting, if I'm understanding correctly.

[creesch]

Hrm, I just reread the thing. Just disable the coloring. I am ok with that.

[eritbh]

Looks like a pretty easy fix if all we want to do is not set a background color for selfpost domains no matter what. Just replace this:

if (percentage >= 10 && domainCount > 4){

With this:

if (percentage >= 10 && domainCount > 4 && !match) {

https://github.com/creesch/reddit-moderator-toolbox/blob/master/extension/data/modules/historybutton.js#L492

(side note, match could also use a rename to something more descriptive, which I'd do at the same time)