Notes for submissions, modmail, and domains

[amici-ursi]

This issue consolidates #442, #328, #264, and some of the weight on @agentlame's shoulders.

Some of the brainstorming is in tb_dev, but the short of it is, notes for threads (incuding modmail), domains, and users.

[creesch]

I like the idea, in fact I think there might also be a related issue still floating around for something I envisioned a long time ago (some way to mark a thread as watched where all mods online would get notifications of new comments in watched threads).

There is one downside which is also shared with notes themselves, it requires all mods to have it installed for it to be effective. Not a reason not to do it btw, just something that popped into my mind.

A real issue would possibly be that we'll have to yet another request since (I am assuming) this will have its own wiki storage page. Might affect performance.

I'd still like to have this module though.

Thoughts from previous discussions about this btw:

Good idea, although there is a small issue with domains and subdomains. In some cases you want to leave notes on subdomains (wordpress websites for example) where in other examples the subdomains are effectively the same website.

I think that can be handled by an option in the case of subdomains that says something like "Leave note for main domain []" and in case of subdomains also show the notes for the main domain if they are there

[amici-ursi]

A real issue would possibly be that we'll have to yet another request since (I am assuming) this will have its own wiki storage page. Might affect performance.

In one of @agentlame 's comments, he said that all of the notes could be stored together in the same storage to avoid doing a bunch of separate api calls for each type. I think that's in the irc log saved in the tb_dev comment I linked.

[agentlame]

^ that.

[creesch]

ah, I figured we didn't want to do that due to the storage limits many subs already are hitting.

[agentlame]

I think it will only add one more property: notetype. The current 'user' property would become 'id' and hold a username, domain, or thing_id.

[creesch]

Well I was mostly thinking along the lines of increased note usage. With more places available to make use of notes the usage will increase and that will result in hitting the limits faster. Even more so because mod teams likely to use this probably allready use regular notes fairly heavily. Continuing along that line I thought that splitting it in different storage would be on the table as one of the options :)

Anyway that isn't really important, either way it has some implications that need to be considered. With seperate storage it would be performance with shared storage the limits will likely be an issue.

Also, just to be clear, I love the idea just trying to think ahead of possible stuff we can avoid.