toofar

Results 182 comments of toofar

A test has started failing with beta4 because QWebEngineProfile.isSpellCheckEnabled() is reporting False where it used to be True https://github.com/qutebrowser/qutebrowser/actions/runs/10735316586/job/29772339738 I don't yet understand what the test is supposed to be...

I think there's been a regression in the `content.javascript.clipboard` handling in that the `access` option no longer works. Not 100% sure, but I think what happened is that with the...

Ah, 6.8 is supposed to be releasing [on Tuesday](https://wiki.qt.io/Qt_6.8_Release). I'll have a quick look at the tests and see if I can whip up something around the permissions based on...

> I think that only leaves us with the [Alt shortcut issue](https://github.com/qutebrowser/qutebrowser/issues/8242#issuecomment-2324101356) - @toofar is this still current? Yeah, still happening on the webengine 6.8 branch from November 15 (`d661a4c7eddd7f`)....

Okay, ready for review again, changes I've made: * moved screenshots to be saved in the pytest temp dir * made the CI runners use RUNNER_TEMP as the temp dir...

I'll merge this in a couple of days, I've already used it a couple of times from the branch.

Locally I'm seeing errors like this during teardown sometimes. Not quite sure how to reproduce because I wasn't seeing these when developing it, and it's happily putting screenshots on at...

Ah, thank you. That does show where the assertion is. Here's a stack trace with `--tb=native` as is ```pytb ________ ERROR at teardown of test_sandboxing[disable-seccomp-bpf-True-False-True-You are NOT adequately sandboxed.] _________...

Firstly, my own disclaimer. I'm more in a writing mood than a reading one. So I haven't fully groked your PR yet and am probably making some assumptions. Also this...

For the ones that inherit from TextBase I would vote that they keep inheriting from TextBase, but ideally don't talk to its QLabel widget directly. (Although it's not the end...