redux-ui
redux-ui copied to clipboard
tonyhb
Avoid creating new functions at each render pass. Fixes issue #46 .
There is a problem on how dependencies are setup that cause the CI failures. Tests pass locally. i will have a look at it, also had similar issues like this when first building the project locally
Does this fix the issue with using pure rendering? I'm noticing that every component that uses @ui() in my app re-renders if literally anything changes. I spent some time investigating today and while debugging shouldComponentUpdate I noted that the nextProps.ui is never equal to this.props.ui even when no part of the UI state has been changed.
Yes it would fix it. In the mean-time I've started out my own local state management solution redux-fractal (https://github.com/gcazaciuc/redux-fractal) which doesn't exhibit this problem.
Awesome! Yeah looks like this project isn't being actively maintained, glad to see you've rolled your own. Thanks!
Hey! Apologies for being late, super busy at docker. Lemme take a look and get these merged in if we can :)
On Wed, 5 Oct 2016, 14:01 Matt Miller, [email protected] wrote:
Awesome! Yeah looks like this project isn't being actively maintained, glad to see you've rolled your own. Thanks!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tonyhb/redux-ui/pull/47#issuecomment-251798280, or mute the thread https://github.com/notifications/unsubscribe-auth/AASsAXzy7Ys85UNNETYnI0w-m82OImQ-ks5qxBAbgaJpZM4Iz3zW .
