Tony Holdstock-Brown

Results 98 comments of Tony Holdstock-Brown

@vangent here's a flush on shutdown PR with tests: https://github.com/google/go-cloud/pull/3386. Edit: I've rebased this PR on the flush-on-shutdown PR to clean up the code. In doing so, I've also cleaned...

That would be pretty amazing. It would be really helpful when composing structs together. Maybe we could use prefixes on only composed, anonymous structs like this? http://play.golang.org/p/r7--RLCoAc That way prefix...

Ya, that would be awesome. It would make it far easier to add relations to models without having a ton of composite structs.

Thanks for the comment @rogy. Can you explain why you had to drop redux-ui? Would be interesting to see if we can create a solution that works for you

Hey Josh, Yeah sounds like a good way to do it – you'd hopefully then be able to re-use this over different graph types, instead of coding it into each...

+1 - `Len` is inconsistent. The asserted value comes last, vs EqualValues which comes first. In general, a bunch of these are inconsistent and it's pretty frustrating.

I'd really like the ability to set `*decls.Functions` on an Env directly. We used to be able to achieve setting stdlib functions (or a subset) by configuring `functions.StandardOverloads()` then passing...

Looks as though calling `Check` concurrently on the same AST causes the issue. Changing the CEL call from `Compile` to `Parse` fixes the race (which exposes another in the test...

Nothing other than history! We were calling `Compile` instead of `Parse` prior to caching, and that was kept around. It's now changed, and we do exactly as you say.