Tony Wong
Tony Wong
@Zitzeronion @jbytecode 's assessment is accurate. I'm responsible for actively guiding/managing the project and doing some of the code development in tandem with @lrennels, who as you note is most...
Thanks for the clarification! @Zitzeronion , would a suitable solution be to add a section to the repository README.md file that outlines Author Contributions? Or perhaps more broadly a "Contributions"...
@Zitzeronion @jbytecode I went ahead and added a brief Author Contributions section to the top-level README.md. https://github.com/raddleverse/MimiBRICK.jl/pull/54#issue-1309801567
To keep @jbytecode updated - The comparison was added to the paper, and @Zitzeronion has closed the issue (https://github.com/raddleverse/MimiBRICK.jl/issues/52). Thanks for the useful feedback @Zitzeronion !
## Review checklist for @tonyewong ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
I see that EditorialBot found this as well, but I opened an issue in the repo, regarding an open source license (https://github.com/hydrosolutions/riversCentralAsia/issues/97). Can one be added to the top level...
I don't know if it needs addressing, but just FYI - as I installed, the dependency on package "exactextractr" threw an error message. I had to install it separately in...
@mabesa The example in the README works nicely out-of-box, but I'm having issues running the tests in [riversCentralAsia/tests/testthat.R](https://github.com/hydrosolutions/riversCentralAsia)/[tests](https://github.com/hydrosolutions/riversCentralAsia/tree/master/tests/testthat.R). Specifically, I get: ``` Error in `test_dir()`: ! No test files found...
@mabesa - _Edit: I moved this discussion of the error I saw while running the test functions to an issue in the repo_ (https://github.com/hydrosolutions/riversCentralAsia/issues/100)
I fully support the no-laptop family holiday rules!