tony

Results 67 comments of tony

@wannabesrevenge is this still an issue for you? If so can you say why you need to use Grpc.Tools is this way?

The code generation needs further changing to fully support handline NRT. See https://github.com/grpc/grpc/pull/33507#discussion_r1252792691 e.g. allowing message fields to be set to null, `Equals`, `MergeFrom`, and removing redundant null checks elsewhere.

@ogxd Fields within a message that themselves are messages can be assigned null. For example, proto file: ```proto message Person { string name = 1; int32 id = 2; //...

I think there is a lot more work to be done. Adding `#nullable enable annotations` rather than `#nullable enable` hides a lot of potential problems. As an experiment I took...

> > I think there is a lot more work to be done. Adding `#nullable enable annotations` rather than `#nullable enable` hides a lot of potential problems. > > As...

> What are the warnings? Nullable warnings shouldn't come from generated code. > > I'm guessing the problem is Google.Protobuf itself isn't annotated. `#nullable enable annotations` could be a short...

I've started looking at this in more detail to see if I can complete the work. Currently there are some issues with the existing tests failing after some of the...