Tony Trinh

Results 75 comments of Tony Trinh

The WebKit team closed the issue as not reproducible. Are you still seeing the issue?

Also encountered this issue. Here's a couple more repros: * [w/Vue CLI](https://stackblitz.com/edit/vue-nested-custom-elements-lose-styles-vue-cli?file=src%2FApp.ce.vue) * [w/Vite](https://stackblitz.com/edit/vue-nested-custom-elements-lose-styles?file=src%2FApp.vue)

@RStyrman I can't reproduce your symptoms (no errors for me using original code from [ep58-firebase-db-demo](https://github.com/Polymer/polycasts/tree/master/ep58-firebase-db-demo)). Can you provide details about your environment and steps to reproduce? Here's my info for...

Does CTRL+F5 actually clear the cache before reloading? Try opening DevTools, then right-click the refresh button, and choose "Empty cache and hard reload". http://superuser.com/questions/220179/how-can-i-do-a-cache-refresh-in-google-chrome

@FezVrasta That's not the same issue.

@patak-dev I tried using esbuild's `define` option, but only valid identifiers are allowed, so these defines would cause an esbuild error because the identifiers end with `.`: https://github.com/vitejs/vite/blob/23c9259aa31424d96fdc87f61236fd3b84aed2c3/packages/vite/src/node/plugins/define.ts#L21-L23 https://github.com/vitejs/vite/blob/23c9259aa31424d96fdc87f61236fd3b84aed2c3/packages/vite/src/node/plugins/define.ts#L52 This...

@posva Oh, I missed those PRs. However, they appear to be outdated, as they no longer compile. Plus, I believe they'll introduce a breaking change for users. I'll comment in...

@posva I agree, and the current code already allows that 😄

@gajus A couple notes about your [proposed code](https://github.com/vitejs/vite/pull/9437#issuecomment-1199253025) below: > ```js > for (const dep of deps) { > // @ts-ignore > dep = assetsURL(dep, importerUrl) > // @ts-ignore >...