vscode-theme-alabaster icon indicating copy to clipboard operation
vscode-theme-alabaster copied to clipboard

Rust support

Open ghost opened this issue 8 years ago • 8 comments

Currently only comments are highlighted, it'd be great to have full support

ghost avatar Oct 21 '17 13:10 ghost

Strings and numbers (constants) are too. This is a minimalist theme, I don’t highlight anything else apart from those and comments.

screen shot 2017-10-21 at 22 36 15

tonsky avatar Oct 21 '17 19:10 tonsky

Oh, I get it. So, the only thing that is missing are the global definitions (as stated in the README)? For example, on the following photo A, B, C, D, E, F, G, H and i: image

ghost avatar Oct 22 '17 13:10 ghost

This is a problem with Rust syntax plugin for VS Code. It doesn’t mark up function definition differently from function invocation. And I want to highlight definitions only (entity.global class in syntax)

tonsky avatar Oct 22 '17 15:10 tonsky

Upon further research, the class should probably be named meta.definition (meta.definition.function.rust and meta.definition.type.rust). I could add that to the theme, but Rust syntax would still need to be updated. Also I’ll need to update Clojure syntax because it puts meta.definition at the wrong token. After that I could update the theme

tonsky avatar Oct 22 '17 15:10 tonsky

^ is this correct? (https://github.com/Microsoft/vscode/pull/36748)

ghost avatar Oct 23 '17 12:10 ghost

I think it should be both: entity.name and meta.definition. You can specify multiple classes:

"name": "entity.name.function.rust meta.definition.function.rust"

tonsky avatar Oct 23 '17 16:10 tonsky

Waiting on https://github.com/atom/language-clojure/pull/75

tonsky avatar Nov 27 '17 15:11 tonsky

also https://github.com/zargony/atom-language-rust/pull/123 I'm not sure if they'll ever merge it though, it looks dead

ghost avatar Nov 28 '17 17:11 ghost