rum

rum copied to clipboard

derived-atom: remove watches on source atoms

5

When using `derived-atom` a watch is added to all source atoms but there's no way to remove these watches potentially causing stale watches when the derived atom is no longer...

martinklepsch

When using `set-warn-on-interpretation!`, the generated warnings look like ``` WARNING: interpreting by default at #'cljs.analyzer/*cljs-file*:125:1 attrs64469 Inferred tag was: #{any} ``` It might be better if instead of `#'cljs.analyzer/*cljs-file*` it...

lassemaatta

GitHub: https://github.com/hulunote/hulunote https://github.com/hulunote/hulunote/blob/master/src/cljs/hulunote/core.cljs#L101 @tonsky

xlisp

Hydration not fully compatible with React 18

4

Attempting to hydrate while using React 18 results in the following warning: > react-dom.development.js:87 Warning: ReactDOM.hydrate is no longer supported in React 18. Use hydrateRoot instead. Until you switch to...

simongray

How to use daiquiri.core/html ?

9

Can not find this function :  @tonsky

xlisp

React v16.3

14

Tracking issue for React 16.3 API changes: https://reactjs.org/blog/2018/03/29/react-v-16-3.html Let's discuss these changes before starting with implementation, cc @tonsky @piranha @DjebbZ @jetmind (mention more people) ## ~[Official Context API](https://reactjs.org/blog/2018/03/29/react-v-16-3.html#official-context-api)~ Not sure...

roman01la

ClojureScript >=1.11.51 seems to break Rum

3

There was a previous issue opened https://github.com/tonsky/rum/issues/253 Using the following snippet taken for one of the examples and simplified: ``` (rum/defc value < rum/reactive [*ref] [:code (pr-str *ref #_(rum/react *ref))])...

yenda

`with-key` and `with-ref` Removing children?

2

The `rum.core/with-key` and `rum.core/with-ref` functions call the underlying [React `.cloneElement`](https://reactjs.org/docs/react-api.html#cloneelement) function to create a new React component that includes the supplied key or ref, respectively. Both [with-key](https://github.com/tonsky/rum/blob/4ff9ddc98d65f1a287bab2f02dcaa0a718cd16b8/src/rum/core.cljs#L312) and [with-ref](https://github.com/tonsky/rum/blob/4ff9ddc98d65f1a287bab2f02dcaa0a718cd16b8/src/rum/core.cljs#L325) use...

zonotope

require-lazy macro unnecessarily prescriptive about namespace/module structure

1

Hi there! I attempted to use the `rum/require-lazy` macro for code-splitting modules but ran into some unexpected behavior with the module-loading logic. I have the following (simplified) build config and...

alexdao3

## Hot to reproduce rum version: 0.12.3 react & react-dom version: 17.0.2 ```clojure (defonce the-count (atom 0)) (rum/defc counter < rum/reactive { :did-mount (fn [] (println "did mount")) :should-update (fn...

thezjy