FiraCode icon indicating copy to clipboard operation
FiraCode copied to clipboard

Less than before dollar sign: <$

Open a-pav opened this issue 1 year ago • 8 comments

Less than before dollar sign doesn't look how it should.

fira-code-issue

This was on VSCodium with below settings:

"editor.fontFamily": "'Fira Code'",
"editor.fontLigatures": "'zero', 'cv02', 'cv15', 'cv30', 'ss01', 'ss02', 'ss03', 'ss04', 'ss05', 'ss08', 'calt'",

a-pav avatar Sep 14 '22 07:09 a-pav

~~I checked other variants and this is not the case with "editor.fontFamily": "'Fira Code Regular'"~~ But Light, Retina and Medium had the same effect as using 'Fira Code' alone.

Edit: Later I realized that 'Fira Code Regular' does not work. The editor was falling back to its default font, I guess.

a-pav avatar Sep 14 '22 07:09 a-pav

That looks correct to me 🤔

wopian avatar Sep 14 '22 14:09 wopian

Yeah what’s wrong?

tonsky avatar Sep 14 '22 19:09 tonsky

That looks correct to me thinking

Yeah what’s wrong?

I'm not sure, but doesn't that look like a completely new character to you, the one on the right side of = sign? Why is < blended into $ like that, when there's no space between them? Is there a kind of semantic reason for this?

I've seen it in jQuery and bash scripts, in all cases, < was not part of the meaning of what was coming after it, usually things like$(...) or ${...} for example.

And if that is the preferred look, then why <=$ aren't blended together in the same way? (I'm not saying that they should!) image

a-pav avatar Sep 15 '22 19:09 a-pav

I think those come from Haskell? I’m not sure

tonsky avatar Sep 15 '22 20:09 tonsky

Yes https://hackage.haskell.org/package/base-4.8.2.0/docs/Data-Functor.html#v:-60--36--62-

(<$, <$> and $>)

wopian avatar Sep 16 '22 01:09 wopian

I think those come from Haskell? I’m not sure

Yes https://hackage.haskell.org/package/base-4.8.2.0/docs/Data-Functor.html#v:-60--36--62-

(<$, <$> and $>)

Oh, I see. That should look really nice in a haskell file. But I wonder how many other languages have a similar semantics? I think it would have been better if this was enabled through a ligature option. Even haskell developers need to deal with JS and bash scripts from time to time, I imagine.

a-pav avatar Sep 16 '22 05:09 a-pav

Yes, they make a good case for stylistic set

tonsky avatar Sep 16 '22 19:09 tonsky