gcal-cli icon indicating copy to clipboard operation
gcal-cli copied to clipboard

generateUrl opens browser automatically

Open mcamara opened this issue 7 years ago • 4 comments

For lazy people (as me), copying and pasting the url is too much hassle. With this small fix, the url is automatically open in user's default browser.

Thanks for the good work!

mcamara avatar Sep 18 '17 06:09 mcamara

Thanks for the PR!

A couple of things:

  • Maybe it's not a good idea to open the browser without asking first (plus it would be a breaking change). Doing it through an option could be a better idea (something like $ gcal generateUrl -o.

  • It needs to be cross-platform, using opn it could be implemented easily.

toniov avatar Sep 18 '17 07:09 toniov

You're right, I always forget windows users! I'll fix it later!

mcamara avatar Sep 18 '17 07:09 mcamara

I've made the changes we talked about. What do you think now? 😸

mcamara avatar Sep 21 '17 10:09 mcamara

Thanks! Looks good!

Besides the comments, if you add the new option to help.js we are good to go I think!

toniov avatar Sep 21 '17 12:09 toniov