WinUAE icon indicating copy to clipboard operation
WinUAE copied to clipboard

Published 20 hours ago • verified publisher icon tonioni

debugmem.cpp@branch_stack_push can overflow

Open BartmanAbyss opened this issue 2 years ago • 2 comments

stackframecnt and stackframecntsuper are not checked against MAX_STACKFRAMES. Had a case where it overflowed, corrupted the heap and crashed WinUAE.

BartmanAbyss avatar Nov 27 '22 17:11 BartmanAbyss

Whats the best option? Do nothing (+log warning message?) if limit reached?

tonioni avatar Nov 28 '22 17:11 tonioni

Hmm.. dunno. maybe warn once + disable stackframes altogether. at this point there's probably some infinite loop going on anyway.

BartmanAbyss avatar Nov 28 '22 18:11 BartmanAbyss

Fixed in 4.10

tonioni avatar Dec 25 '22 18:12 tonioni