OpenKeeper icon indicating copy to clipboard operation
OpenKeeper copied to clipboard

Published 20 hours ago • verified publisher icon tonihele

Migrate to the new animation system

Open Trass3r opened this issue 2 years ago • 2 comments

Found this old #362 branch and rebased fwiw.

Trass3r avatar Jul 11 '22 11:07 Trass3r

What is the status of this? I didn't try the code yet, do the different animation modes still work?

tonihele avatar Aug 14 '22 15:08 tonihele

So far I couldn't spot any regressions. But please feel free to test it yourself.

Trass3r avatar Aug 14 '22 18:08 Trass3r

On 3.6 jME there will be native tweens for the deprecated loop modes. So lets look at this then.

tonihele avatar Jan 08 '23 12:01 tonihele

I see. https://github.com/jMonkeyEngine/jmonkeyengine/releases/tag/v3.6.0-alpha1

Trass3r avatar Jan 08 '23 12:01 Trass3r

Would we need to use AnimLayer then? https://github.com/jMonkeyEngine/jmonkeyengine/pull/1845

Trass3r avatar Jan 31 '23 09:01 Trass3r

Hmm, not sure, it was this PR https://github.com/jMonkeyEngine/jmonkeyengine/pull/1849/files.

tonihele avatar Jan 31 '23 16:01 tonihele

Some enhancement to new animation system by @Ali-RS in https://github.com/jMonkeyEngine/jmonkeyengine/pull/1845

Added a Loop tween to Tweens factory class. Supports looping by count… by @Ali-RS in https://github.com/jMonkeyEngine/jmonkeyengine/pull/1846

Added Tweens.cycle() and Tweens.invert() methods by @Ali-RS in https://github.com/jMonkeyEngine/jmonkeyengine/pull/1849

Trass3r avatar Jan 31 '23 18:01 Trass3r

It has landed: https://github.com/jMonkeyEngine/jmonkeyengine/releases/tag/v3.6.0-stable

Trass3r avatar Mar 24 '23 23:03 Trass3r

Yeah, I finally got around to test this. It seems to work.

I tried to use the Tween.cycle in the AnimationLoader rather than tamper with the Global Animation Speed. But that resulted in doors spawning as opened. Well, need to check this at some point.

So yes, fine by me. Ready to merge?

tonihele avatar May 21 '23 17:05 tonihele