vue-tweet-embed icon indicating copy to clipboard operation
vue-tweet-embed copied to clipboard

Published 20 hours ago • verified publisher icon tonickkozlov

Vue 3 compatibility

Open jacksongross opened this issue 1 year ago • 5 comments

  • Update vue package and peerDependency to use version 3
  • Update puppeteer as it was super old
  • Update syntax for render function to be Vue 3 compatible
  • Fix tests to work with changes
  • Fix bug where non-integer tweetId would throw an uncaught error in the iframe preventing the widget from loading, and not being caught by this package so the error handling wouldn't work correctly.

jacksongross avatar Aug 01 '22 05:08 jacksongross

@jacksonGross, Can you please confirm when this fix will be deployed into Production?

Fresh-Dev-zunairzakir avatar Aug 02 '22 10:08 Fresh-Dev-zunairzakir

@tonickkozlov , Can you provide some update on this merge request?

Fresh-Dev-zunairzakir avatar Aug 10 '22 08:08 Fresh-Dev-zunairzakir

@Fresh-Dev-zunairzakir I've published my fork here if you'd like to use it -- https://github.com/jacksonGross/vue-tweet-embed

jacksongross avatar Nov 25 '22 00:11 jacksongross

@jacksongross many thanks for working on this fix. Sorry I didn’t have much time to look into it earlier. Could you please try to see why the builds are not completing? Then we can merge.

tonickkozlov avatar Nov 25 '22 09:11 tonickkozlov

~~@tonickkozlov I don't have access (or can see a way) for me to check the issue with the builds.~~ Can see this PR never triggered a build, which makes sense why it says it's still waiting to be reported in the PR status checks. Not sure why this isn't being picked up here, any ideas?

jacksongross avatar Nov 28 '22 02:11 jacksongross