tonerdo
v2.0.x - v2.0.5 - Added compatibility framework support for v4.5 - v4.8 / Core 2.2 & 3.0 / Standard 2.0 & 2.1
Updated to support .NET Core 2.1. Updated to support .NET Standard v2.0. Updated to support .NET Framework v4.7.2. Consolidated redundant code and expressions. Repacked for multi-frameworks. Updated versioning. Updated test projects. Signed assembly for GAC and other project integrations.
@Latency Thanks for this, I'd take a look. In the meantime let's keep all indentations Allman Style https://en.wikipedia.org/wiki/Indent_style#Allman_style
Do I need to repack to code-format or? You pull it.. and then check it back in on your end if you have Allman code format styles setup on your end.
I use K&R here. Have been for 20+ yrs since I came from a Linux/UNIX background.
@Latency it should be quite straightforward to change. If you're using any Visual Studio product you can format with some shortcut keys. Allman style is a C# best practice
Went through and updated the merge conflicts.
There are some concerns with the MSBuild automation code I had put in for creating artifacts directory and NuGet packages in the distro.
I managed to create a version / tag release for v1.2.1 w/ NuGet binaries on my forked repo, but ultimately, I feel this should be merged as well.
Thoughts, comments, feedback?
Bah, somebody is making modifications to 'useHistory'. Is this new code or stale? Looking at the timestamps, I can't see any changes for +5 mo.
Can you tell me what is going on here? I thought I had the latest check-in from the tracking history.
Thank you @tonerdo for updating my latest build configurations in my previous PR!!!
Release Notes v2.0.1:
Fixed unit tests compilation errors and missing/invalid tab completion parameters.
Added support for .NET Framework v4.5 / v4.6.2 & Standard 1.3 for backwards compatibility.
Do me a favor and merge my tracking history from this PR. I see you cherry picked my efforts into the master copy already. Please give credit where credit is due for my efforts!
-Thank you!
Removing framework .NET Standard support for v1.3. Use v2.0+.
.NET Core 2.0 is deprecated as of September 2018 due to failure to upgrade bug. Use replacement .NET Core 2.1.
ReadLine.nupkg repacked!!!
Please merge as it contains rubberducky's PR from 3 months ago.
Master pull merged 9/9/2018. Use this PR as final release!!!
Added target support for .NET Core 3.0 and updated .NET Core 2.1 -> 2.2.
Appveyor does not support the new Core 3.0 run-times yet. Therefore, appveyor is failing at this time.
Please push through anyway!
- Changed build configurations to remove v4.6.2 as it is no longer supported by default installation configuration for VS2017-2019. Reverting to v4.6.1 instead.
- Fixed MSBuild target conditions to exclude non-existent dependencies for target platforms.
- Added build property variable for artifact path directory specifications.
- Adding support for Core 3.0 + .Net 4.8 (pre)
- Not supporting Core 2.1. Use v2.2 instead.
This is bothering to me. I tried to run unit tests for XUnit (original) and switched it out to NUnit (current) which yield the identical results.
The problem is that under release test, the Console handle is not being set. When Console2 class goes to make the Console.X calls... it throws.
I tried setting the stream in to it and during [SetUp] of the test, but it still throws. Not sure what's going on here. If anybody cares to look into it further, I will restore the test.ps1 for Appveyor.
This is the new release. for the appveyor reason, I decided to take out target support for Framework 4.8 and Standard 3.0.
The next release I will put them in.. which will be latest and no code differences.
@Latency I just cloned your master branch and ran the demo app and history fails.
You don't have "Issues" enabled on your fork so I thought I would respond here. You can see screencast of the error here. https://www.screencast.com/t/YiIZ01FU7Dgs
@Latency @tonerdo What is the state of this PR? Are you going to merge it with master and publish to nuget?
I was wondering the same thing! @tonerdo needs to pull it. He is not letting me take it over in his absence. Still trying to get permissions.
You should be able to download it manually off my build, but it won't be pushed up on NuGet.org yet since he has access to that account too.
Release Notes v2.1.3:
Known GitHub issue with appveyor not supporting targets for .NET Core 3.0 yet. Moved SRC and Test folders to root directory. Refactored static ReadLine class to a true singleton. Changed unit tests to use NUnit instead of XUnit. Patched fix for Issue #59. (Add option to return CTRL+C)
