mytonctrl icon indicating copy to clipboard operation
mytonctrl copied to clipboard

[Bug] False positive error in mytoncore.log: `Validator pool not found or not ready`

Open begetan opened this issue 1 year ago • 3 comments

===[ Local validator status ]=== Version mytonctrl: b9d5937 (master) Version validator: 8a9ff33 ((HEAD)

We discovered recently that normally operating validtor by mytocnore service is producing the follow message in logs in some period of the network validation cycle:

tail -f /usr/local/bin/mytoncore/mytoncore.log -n 10000 | grep error

[error]   26.01.2024, 15:31:34.056 (UTC)  <Elections>   Elections error: Stake less than the minimum stake. Minimum stake: 300000.0
[error]   26.01.2024, 15:51:50.090 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   26.01.2024, 16:01:50.593 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   26.01.2024, 16:11:51.727 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   26.01.2024, 16:21:52.350 (UTC)  <Elections>   Elections error: Validator pool not found or not ready

We believe it is a false positive error, because both pools participating in the election and getting rewards.

begetan avatar Jan 29 '24 15:01 begetan

This happens because the elections have already begun, but the pool is not ready for work yet (the blocking time has not passed) This is normal behavior for some time after the election begins. Alternatively, we can change the message category to warning or debug

igroman787 avatar Feb 05 '24 09:02 igroman787

I can confirm that this event doesn't affect the normal operation, thus it shall not be in error category

Let you change the log level to warning or may be info? For example, there is info message elections have not begun yet which is pretty much the same about.

I would see also more descriptive message, e.g. Validator pool is not ready, the blocking time has not passed.

I am not sure if the same check is used for the "Validator pool not found" case. In this case it needs to be split between error and info/warning message.

begetan avatar Feb 09 '24 10:02 begetan

Help,I am facing the issue, but sadly, mytonctrl had not to call "new stake" to single norminator pool contract in Elections

[error]   08.09.2024, 22:23:21.536 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   08.09.2024, 22:33:21.789 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   08.09.2024, 22:43:22.054 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   08.09.2024, 22:53:22.335 (UTC)  <Elections>   Elections error: Validator pool not found or not ready
[error]   08.09.2024, 23:03:22.720 (UTC)  <Elections>   Elections error: Validator pool not found or not ready

My single norminator pool contract is deployed in https://orbs-network.github.io/single-nominator-client/ and then import_pool.

macrocan avatar Sep 09 '24 07:09 macrocan