Tom Vo

CDAT Migration Phase 2: Refactor `enso_diags` set

3

Just noting that @forsyth2 previously worked on this set.

Todo: - [ ] [Refactor `VarHandler._get_attr_from_climo()`](https://github.com/E3SM-Project/e3sm_diags/pull/677#discussion_r1336444331)

[Bug]: Silent bug in `adjust_prs_val_units()` conditional where `if prs_val0:` will be `False` if `prs_val0` is 0

1

### What happened? #### Overview There is a conditional in `adjust_prs_val_units()` that checks `if prs_val0:` to perform unit adjustment on the prs axis. This is a silent bug in this...

[Bug]: `main` branch not properly renaming original variables to target derived variable key

1

### What happened? `rename()` is not properly renaming original variable names to target derived variable keys. This bug has not been causing any issues in `e3sm_diags` and we don't write...

[Bug]: `cosp_histogram_standardize()` conditional for adding bounds is incorrect and default bounds length might not align with coordinates

5

### What happened? In PR #748, I found a silent bug in a conditional statement for handling bounds in `cosp_histogram_standardize()`. https://github.com/E3SM-Project/e3sm_diags/blob/633b52c314325e605fe7f62687cc4d00e5a0a3d5/e3sm_diags/derivations/acme.py#L552-L565 The conditional follows this flow: 1. Check if the...

[Bug]: Regridding time-series variable's climatology from hybrid to pressure levels breaks due to misaligned axes

2

In PR #677, I am doing a complete run of [ex1.py](https://github.com/E3SM-Project/e3sm_diags/blob/main/examples/ex1-model_ts-vs-model_ts/ex1.py) to make sure all of the metrics and plots are successfully generated. The last remaining issue is an `xgcm`...

The `acme.py` file is growing as more derived variables and formulas are being defined. We can explore implementation designs that might be more readable and extensible (e.g,. split file up...