Tom Vo

My proposed solution - [x] 1. Get the list of datasets used in the notebooks -- figure out which ones overlap between notebooks. ```python # Gentle Introduction * "https://esgf-data1.llnl.gov/thredds/dodsC/css03_data/CMIP6/CMIP/CSIRO/ACCESS-ESM1-5/historical/r10i1p1f1/Amon/tas/gn/v20200605/tas_Amon_ACCESS-ESM1-5_historical_r10i1p1f1_gn_185001-201412.nc" #...

> @tomvothecoder In my very quick glimpse I don't see any obviously noticeable issues! Notebooks are looking good to me. It's great to leverage xarray's sample datasets so we don't...

> cc @tomvothecoder do you have time to contribute some tests? I bet we'll simplify a bunch of xcdat this way, and you probably already have tests :) Hi @dcherian,...

Hey @dcherian, quick question. Will this PR add support for using `SeasonGrouper` along with Datetime components (e.g., `ds.time.dt.year`)? For example, if I wanted to perform grouped averaging on year and...

> Yes, I think so this is conceptually similar to `groupby(["time.month", "time.year"])` but we require dict inputs to be explicit > > ```python > ds.coords["year"] = ds.time.dt.year > ds.air.groupby(year=UniqueGrouper, time=SeasonGrouper(["JF",...

Another question: If we're defining custom seasons with months that span the calendar year, those months are from the previous year correct? For example for "NDJFM", "ND" should be from...

I'm writing a few tests right now. How do you want me to add them to your fork branch? > Another question: If we're defining custom seasons with months that...

> Ah nice find. A PR to this branch should be the easiest Gotcha, will do. ## RE: My [comment](https://github.com/pydata/xarray/pull/9524#issuecomment-2477675653) above about annual seasonal averaging. I've attached the Python script...

> Xarray (actual) uses the same year `"ND"` for grouping, while xCDAT (expected, PR #423) uses the previous year `"ND"`. I manually verified that the averages for xCDAT are correct...

I'll try testing if I can soon! Thanks again for this PR @dcherian.