TZStackView icon indicating copy to clipboard operation
TZStackView copied to clipboard

1.3 violates semantic versioning

Open solidfox opened this issue 9 years ago • 7 comments

1.3 includes a load of breaking changes and thus should increase the major version of the library.

http://semver.org

solidfox avatar Sep 19 '16 12:09 solidfox

Sorry.

tomvanzummeren avatar Sep 19 '16 14:09 tomvanzummeren

No worries, just thought I'd tell you before a lot of product owners start complaining about compile errors. Thanks for a great framework!

solidfox avatar Sep 19 '16 14:09 solidfox

I'm finding this as well, Tom.

Are there any intentions to fix this to remove 1.3.0?

chamander avatar Sep 21 '16 02:09 chamander

I don't see what the big deal is. It is just a number. Use 1.2.0 for Swift 2 and 1.3.0 for Swift 3. Done.

tomvanzummeren avatar Sep 21 '16 16:09 tomvanzummeren

Using Carthage as an example:

With the way dependencies are worked out, artifacts such as ~> 1.2.0 will resolve to any version up to, but not including 2.0.0, so projects that are dependent on your work will pull 1.3.0 if they have specified ~> 1.2.0.

This means that any projects expecting compatibility for any 1.x.x build up to version 2.0.0 don't actually get it--even though your API may not have changed.

This deters implementers from running

carthage update

to seek patch version updates that might fix issues with the library and encourages

github "tomvanzummeren/TZStackView" == 1.2.0

Integration gets a little more difficult--less straightforward.

I understand if you feel this doesn't warrant action.

Thank you for the framework; I hope I can help by contributing, some day. 🙂

chamander avatar Sep 21 '16 21:09 chamander

Ok, next time I will do this properly. For now the 'damage' is done and I am also not sure if I can delete a Cocoapod version.

tomvanzummeren avatar Sep 22 '16 11:09 tomvanzummeren

You're welcome to contribute by the way, but there is not much to be done. This framework is almost obsolete anyway, since less than 10% run iOS 8 right now.

tomvanzummeren avatar Sep 22 '16 11:09 tomvanzummeren