generatepress icon indicating copy to clipboard operation
generatepress copied to clipboard

Dark mode

Open tomusborne opened this issue 1 year ago • 4 comments

We should look at what's needed to add a dark mode feature.

tomusborne avatar Apr 13 '23 01:04 tomusborne

Theres a good topic here relating to color swapping for darkmode, and the OPs JS Fiddle is still live and covers the basics: https://generatepress.com/forums/topic/is-it-possible-to-fire-generate_element_display-using-wp-hooks/#post-2179091

However this is not a simple plug and play feature. There is more than colors to be considered.

Lets discuss.

diggeddy avatar Apr 13 '23 11:04 diggeddy

Why not Style Variations? Check out https://make.wordpress.org/core/2022/05/03/global-styles-variations-in-wordpress-6-0/

example: https://wordpress.org/themes/spectra-one/

I know this has to do with FSE, but why tinker with old techniques when there will soon be much better solutions?

SchneiderSam avatar May 10 '23 05:05 SchneiderSam

GeneratePress is light and fast, and this is what makes me use it in projects always, whether for my own projects or my clients' projects The dark mode is added as an option for the visitor, which I think is very important Many customers request this thing, and when using the plug-in it causes slowness, and this is very annoying. I used a lot of plug-ins, but they are all bad

I hope you seriously consider adding this feature to GeneratePress

Ghazi3 avatar Jul 19 '23 09:07 Ghazi3

There are plugins that do this quite well and most browsers also have this feature. Similar to @SchneiderSam if anything, I'd like to see an assortment of downloadable colour palettes that can be applied within the customiser.

oicurmt3 avatar Jan 28 '24 03:01 oicurmt3