generatepress icon indicating copy to clipboard operation
generatepress copied to clipboard

Navigation location bug in RTL

Open leohsiang opened this issue 4 years ago • 1 comments

Reference: https://generatepress.com/forums/topic/different-header-layout-per-language/#post-1764120

leohsiang avatar May 07 '21 00:05 leohsiang

Not sure of the best way to "fix" this.

I suppose we could set the navigation location default to "nav-float-left" (https://github.com/tomusborne/generatepress/blob/3.0.3/inc/defaults.php#L39) like we do here: https://github.com/tomusborne/generatepress/blob/3.0.3/inc/defaults.php#L35

Trouble with changing defaults is we need to consider backward-compatibility.

tomusborne avatar Jun 11 '21 18:06 tomusborne