vault-assessment-prometheus-exporter icon indicating copy to clipboard operation
vault-assessment-prometheus-exporter copied to clipboard

Adding pre-commit

Open eugenedavis-tomtom opened this issue 2 years ago • 0 comments

To save time and computation power, it would be good to add at least the short-running PR checks to a pre-commit hook.

It could run:

  • black --check
  • pylint
  • mypy
  • pytest (this could be reduce to a subset of tests if pytest test-time increases)
  • hadolint Dockerfile lint
  • bandit
  • version check

Docker builds and security scans should probably be skipped.

eugenedavis-tomtom avatar Jun 15 '22 11:06 eugenedavis-tomtom