Tom Stitt

Results 13 comments of Tom Stitt

I can now build and run the js version but there is at least on thing that isn't working yet. I saw that the `CallKeySequence` call was moved from `aux_js.cpp:startVisualization`...

The JS target seems to work well for me now, I slacked a copy to @tzanio and @kanye-quest so check it out if you want

The mac jobs are failing due to `GitHub Actions has encountered an internal error when running your job`, any ideas?

This is great! it would be awesome if we could also have a warning printed if we didn't use a specialization

> @tomstitt, do you think this will be ready in time for [mfem-4.6](https://github.com/mfem/mfem/pull/3841)? Should be (based on the mid September date), I'm almost done testing locally. Next I need to...

> @tomstitt, is this ready for review? No.. not yet. It's taking me longer to get full backwards compatibility than expected. We also need https://github.com/hypre-space/hypre/tree/gpu_init, which isn't merged yet but...

> Update: This functionality is now in a Hypre release version (2.31, after [hypre-space/hypre#1068](https://github.com/hypre-space/hypre/pull/1068)). Great! Assuming we want this by default I can update the PR to check for 2.31

> @tomstitt -- Can you add an item about this in `CHANGELOG`? Done!

Thank you @sebastiangrimberg for fixing the unit tests! I completely neglected those =| > I am also getting the inverse of the behavior I'd expect for the unit tests, but...

> @tomstitt, do we need to expedite this for the mfem-4.7 release? No, we're okay, thank you though !