Tom Parrott
Tom Parrott
Do you know how long it will take to get the snapstore updated? We may need to revert this change if its going to take a while.
> So while it's true that this can't currently be done in dqlite, I tend to think that in most cases (if not all) this pattern leads to less-than-optimal data...
You can do something like this to set a default timeout if not specified by the passed context: ```go _, ok := ctx.Deadline() if !ok { // Set default timeout...
FWIW LXD sets a default timeout on the transaction rather than each query: https://github.com/lxc/lxd/blob/master/lxd/db/query/transaction.go#L15-L16 Which has been useful while we transition to passing context into each query too. It also...
Does cancelling the transaction not end the query too. I've not observed LXD getting stuck on Execs when the transaction is cancelled.
> Except the context isn't available via the `*Tx` and the conn does have a context, except it's deprecated. So we shouldn't attempt to use it. Agreed. I suppose if...
Maybe the non tx related functions, such as plain `Exec` `Ping` etc. could have a default timeout added, and functions that accept a context like `ExecContext`, `BeginTx` etc could add...
We need to remove the code from LXD first as part of https://github.com/canonical/lxd/issues/15622 before removing from the snap.
@simondeziel needs a rebase please
This is an effective duplicate of https://github.com/canonical/lxd/issues/10654 and is caused by the upstream OVN bug: https://github.com/ovn-org/ovn/issues/144