Tom Parrott

Results 1094 comments of Tom Parrott

> > Ah yeah I'm happy to see that lxd init is using network option and not parent: > > True, but only if creating a **new** bridged network: >...

> Correct me if I'm wrong, but we detect managed networks by looking into database for its presence? Yeah, feels like we should use "network" for an existing managed bridge...

@roosterfish please can you explain further what has changed to require this now, or has the panic scenario always existed?

> I am wondering if a better approach would be to instead perform the validation when setting the respective value. A read operation would then just return a valid value....

Do we even need the Config struct anymore? Can we use a map everywhere like we do with the others and use shared.FalseOrEmpty etc

It would also allow resolving the different behaviors of defaults compared to rest of system

Should this be closed or rebasee now?

@MggMuggins if you are using patches from Incus then you need to cherry pick specific commits to maintain attribution and add the Apache 2.0 license footer to the commit message...