Tom Parrott

Results 1094 comments of Tom Parrott

Moved back to draft status as not active.

@masnax shall we close this until you are able to work on it again? To get the open PR list down.

> I will have to look at the `d.GetInstanceConsoleLog()` to see how console logs are handled Would you mind if we close this PR for now until you're ready? Thanks

The reproducer steps are in https://github.com/canonical/lxd/issues/12795

> @tomponline I don't know what's the current recommendation on binding LXD services on IPs assigned to devices it manages itself? Should we bind our services later or a few...

@escabo this sounds like a similar class of bug to https://github.com/canonical/lxd/issues/12185 perhaps we can fix together?

> I feel this warrants an API extension but none was added in Incus. Agreed. It would also be useful to add some tests to lxd-ci for this if possible?

> So I should add the extension and collapse all those commits into one, with proper attribution, right? No, just add a single api extension commit (see https://github.com/canonical/lxd/blob/main/CONTRIBUTING.md#commit-structure) and that...

It doesn't look like there are any doc commits either so it'll also need something updated in the docs to indicate those keys are suitable for VMs and what they...