Tom Parrott
Tom Parrott
jenkins: test this please
@brauner are you able to re-run the failed test and see if it completes? Thanks
@caglar10ur the link above is broken now, but I think you're referring to this article https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis Sounds good :)
https://github.com/canonical/go-dqlite/pull/194
@cole-miller I think @MathieuBordere was already working on it last time I asked him. You may want to pick up with him about how far he got with it.
@MathieuBordere once this is merged, please can you create a new release version and tag for this so we can update LXD's dependencies ready for LXD 5.1?
> With this change you would be able to re-merge the dqlite change that was reverted, right? Yes indeed.
I think that it is fine as it is as it will find EOF anywhere in the error chain (it will call Unwrap internally).
@MathieuBordere can you fix up the test golint issues please (looks like just comment annotation issues) https://github.com/canonical/go-dqlite/pull/186/files "Unchanged files with check annotations Beta "