kubernetes_asyncio
kubernetes_asyncio copied to clipboard
Fallback to merge patch
Add fallback to merge patch if strategic merge patch is unavailable, as is the case for the custom objects API.
Codecov Report
Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
Project coverage is 26.91%. Comparing base (
84e4e28) to head (d886878). Report is 13 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| kubernetes_asyncio/e2e_test/test_client.py | 0.00% | 14 Missing :warning: |
| kubernetes_asyncio/client/api_client.py | 0.00% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 26.91% 26.91% -0.01%
==========================================
Files 799 799
Lines 98316 98332 +16
==========================================
Hits 26463 26463
- Misses 71853 71869 +16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
I will get to the tests when I can.
I will get to the tests when I can.
@tomplus I started writing tests, but I noticed that the unit tests for the CustomObjects API are only stubs. There are e2e tests, but there are no e2e tests for CustomObjects (excluding the DynamicClient). Would you like these e2e tests to be added (which would include creating a CRD, creating a custom object of the CRD's type, and then patching the new custom object)?
Absolutely, it'd be fantastic to have such tests.